Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

phpstan: added some return statements to match parent class or interface #2574

Merged
merged 4 commits into from
Sep 10, 2022
Merged

phpstan: added some return statements to match parent class or interface #2574

merged 4 commits into from
Sep 10, 2022

Conversation

sreichel
Copy link
Contributor

@sreichel sreichel commented Sep 8, 2022

Description (*)

Added some return $this to match parent class or interface.

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All automated tests passed successfully (all builds are green)
  • Add yourself to contributors list

@github-actions github-actions bot added Component: Adminhtml Relates to Mage_Adminhtml Component: Catalog Relates to Mage_Catalog Component: CatalogInventory Relates to Mage_CatalogInventory Component: Checkout Relates to Mage_Checkout Component: Core Relates to Mage_Core Component: Customer Relates to Mage_Customer Component: Index Relates to Mage_Index Component: Payment Relates to Mage_Payment Component: PayPal Relates to Mage_Paypal Component: Sales Relates to Mage_Sales Component: Wishlist Relates to Mage_Wishlist environment phpstan labels Sep 8, 2022
@sreichel sreichel changed the title phpstan: added some return $this phpstan: added some return statements to match parent class or interface Sep 8, 2022
@elidrissidev elidrissidev merged commit 97e0b70 into OpenMage:1.9.4.x Sep 10, 2022
@github-actions
Copy link
Contributor

Unit Test Results

1 files  ±0  1 suites  ±0   0s ⏱️ ±0s
0 tests ±0  0 ✔️ ±0  0 💤 ±0  0 ❌ ±0 
7 runs  ±0  5 ✔️ ±0  2 💤 ±0  0 ❌ ±0 

Results for commit 97e0b70. ± Comparison against base commit a5541ff.

@sreichel sreichel deleted the phpstan/daily branch September 10, 2022 20:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fballiano fballiano fballiano approved these changes

@ADDISON74 ADDISON74 ADDISON74 approved these changes

@elidrissidev elidrissidev elidrissidev approved these changes

Assignees
No one assigned
Labels
Component: Adminhtml Relates to Mage_Adminhtml Component: Catalog Relates to Mage_Catalog Component: CatalogInventory Relates to Mage_CatalogInventory Component: Checkout Relates to Mage_Checkout Component: Core Relates to Mage_Core Component: Customer Relates to Mage_Customer Component: Index Relates to Mage_Index Component: Payment Relates to Mage_Payment Component: PayPal Relates to Mage_Paypal Component: Sales Relates to Mage_Sales Component: Wishlist Relates to Mage_Wishlist environment phpstan
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sreichel @fballiano @ADDISON74 @elidrissidev